Skip to content

perf: reduce routing module bundle size #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

davidlj95
Copy link
Owner

@davidlj95 davidlj95 commented Jan 15, 2024

Keep on shaving #112

Inlining helper to remove dependency injection bytes. Manually shortening names from router listener & removing unneeded method. Removing feature of allowing multiple strategies. You can implement a multi-strategy strategy if you want.

Copy link
Owner Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link

📦 Bundle size (Angular v16)

Git ref: 4512f93

Module file Size Base size Difference
ngx-meta-core.mjs 3178 bytes (3.2KiB) 3178 bytes (3.2KiB) No change
ngx-meta-json-ld.mjs 470 bytes (470B) 470 bytes (470B) No change
ngx-meta-open-graph-profile.mjs 423 bytes (423B) 423 bytes (423B) No change
ngx-meta-open-graph.mjs 900 bytes (900B) 900 bytes (900B) No change
ngx-meta-routing.mjs 1131 bytes (1.2KiB) 1522 bytes (1.5KiB) -25.68%: -391 bytes (-391B)
ngx-meta-standard.mjs 1603 bytes (1.6KiB) 1603 bytes (1.6KiB) No change
ngx-meta-twitter-card.mjs 689 bytes (689B) 689 bytes (689B) No change

Copy link

📦 Bundle size (Angular v17)

Git ref: 4512f93

Module file Size Base size Difference
ngx-meta-core.mjs 2921 bytes (2.9KiB) 2921 bytes (2.9KiB) No change
ngx-meta-json-ld.mjs 296 bytes (296B) 296 bytes (296B) No change
ngx-meta-open-graph-profile.mjs 286 bytes (286B) 286 bytes (286B) No change
ngx-meta-open-graph.mjs 734 bytes (734B) 734 bytes (734B) No change
ngx-meta-routing.mjs 928 bytes (928B) 1307 bytes (1.3KiB) -28.99%: -379 bytes (-379B)
ngx-meta-standard.mjs 1444 bytes (1.5KiB) 1444 bytes (1.5KiB) No change
ngx-meta-twitter-card.mjs 525 bytes (525B) 525 bytes (525B) No change

Copy link

📦 Bundle size (Angular v15)

Git ref: 4512f93

Module file Size Base size Difference
ngx-meta-core.mjs 3182 bytes (3.2KiB) 3182 bytes (3.2KiB) No change
ngx-meta-json-ld.mjs 470 bytes (470B) 470 bytes (470B) No change
ngx-meta-open-graph-profile.mjs 423 bytes (423B) 423 bytes (423B) No change
ngx-meta-open-graph.mjs 900 bytes (900B) 900 bytes (900B) No change
ngx-meta-routing.mjs 1131 bytes (1.2KiB) 1522 bytes (1.5KiB) -25.68%: -391 bytes (-391B)
ngx-meta-standard.mjs 1603 bytes (1.6KiB) 1603 bytes (1.6KiB) No change
ngx-meta-twitter-card.mjs 689 bytes (689B) 689 bytes (689B) No change

@davidlj95 davidlj95 merged commit fd4c892 into main Jan 15, 2024
@davidlj95 davidlj95 deleted the stacked/perf-reduce-routing-module-bundle-size branch January 15, 2024 17:53
Copy link

🎉 This PR is included in version 1.0.0-alpha.25 🎉

The release is available on:

Your semantic-release bot 📦🚀

@davidlj95 davidlj95 linked an issue Jan 15, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce bundle size
1 participant