Skip to content

perf: add global consts to reduce dup strings #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

davidlj95
Copy link
Owner

@davidlj95 davidlj95 commented Jan 15, 2024

In order to remove duplicate strings refering to same globals around, adding consts

Also move out JSON LD from globals to make the module less tight to core module

Helps with #112

Copy link
Owner Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link

github-actions bot commented Jan 15, 2024

📦 Bundle size (Angular v15)

Git ref: 2544fac

Module file Size Base size Difference
ngx-meta-core.mjs 3424 bytes (3.4KiB) Not available Not available
ngx-meta-json-ld.mjs 402 bytes (402B) Not available Not available
ngx-meta-open-graph-profile.mjs 423 bytes (423B) Not available Not available
ngx-meta-open-graph.mjs 820 bytes (820B) Not available Not available
ngx-meta-routing.mjs 1131 bytes (1.2KiB) Not available Not available
ngx-meta-standard.mjs 1199 bytes (1.2KiB) Not available Not available
ngx-meta-twitter-card.mjs 651 bytes (651B) Not available Not available
Total 8050 bytes (7.9KiB) Not available Not available

Base size data is not available yet. Try again when the CI/CD has finished running on main branch

Copy link

github-actions bot commented Jan 15, 2024

📦 Bundle size (Angular v16)

Git ref: 2544fac

Module file Size Base size Difference
ngx-meta-core.mjs 3420 bytes (3.4KiB) Not available Not available
ngx-meta-json-ld.mjs 402 bytes (402B) Not available Not available
ngx-meta-open-graph-profile.mjs 423 bytes (423B) Not available Not available
ngx-meta-open-graph.mjs 820 bytes (820B) Not available Not available
ngx-meta-routing.mjs 1131 bytes (1.2KiB) Not available Not available
ngx-meta-standard.mjs 1199 bytes (1.2KiB) Not available Not available
ngx-meta-twitter-card.mjs 651 bytes (651B) Not available Not available
Total 8046 bytes (7.9KiB) Not available Not available

Base size data is not available yet. Try again when the CI/CD has finished running on main branch

Copy link

github-actions bot commented Jan 15, 2024

📦 Bundle size (Angular v17)

Git ref: 2544fac

Module file Size Base size Difference
ngx-meta-core.mjs 3163 bytes (3.1KiB) Not available Not available
ngx-meta-json-ld.mjs 236 bytes (236B) Not available Not available
ngx-meta-open-graph-profile.mjs 286 bytes (286B) Not available Not available
ngx-meta-open-graph.mjs 656 bytes (656B) Not available Not available
ngx-meta-routing.mjs 928 bytes (928B) Not available Not available
ngx-meta-standard.mjs 1072 bytes (1.1KiB) Not available Not available
ngx-meta-twitter-card.mjs 486 bytes (486B) Not available Not available
Total 6827 bytes (6.7KiB) Not available Not available

Base size data is not available yet. Try again when the CI/CD has finished running on main branch

@davidlj95 davidlj95 force-pushed the stacked/perf-add-global-consts-to-reduce-string-dups branch from 0585d90 to 2544fac Compare January 15, 2024 20:13
@davidlj95 davidlj95 enabled auto-merge (squash) January 15, 2024 20:13
@davidlj95 davidlj95 merged commit 3fee59b into main Jan 15, 2024
@davidlj95 davidlj95 deleted the stacked/perf-add-global-consts-to-reduce-string-dups branch January 15, 2024 20:16
Copy link

🎉 This PR is included in version 1.0.0-alpha.27 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant