Skip to content

perf: make JSON metadata resolver a fn #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

davidlj95
Copy link
Owner

@davidlj95 davidlj95 commented Jan 18, 2024

Keep reducing bundle size #112

Also:

  • Removes generics from types. Given used internally, this helps keeping things simple.
  • Changes test names so they're not tied to code for consistency
  • Removes not used anymore MaybeUndefined utility type

Copy link
Owner Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@davidlj95 davidlj95 mentioned this pull request Jan 18, 2024
Copy link

📦 Bundle size (Angular v16)

Git ref: b62ead8

Module file Size Base size Difference
ngx-meta-core.mjs 3054 bytes (3.0KiB) 3172 bytes (3.1KiB) -3.72%: -118 bytes (-118B)
ngx-meta-json-ld.mjs 402 bytes (402B) 402 bytes (402B) No change
ngx-meta-open-graph.mjs 1247 bytes (1.3KiB) 1247 bytes (1.3KiB) No change
ngx-meta-routing.mjs 897 bytes (897B) 897 bytes (897B) No change
ngx-meta-standard.mjs 940 bytes (940B) 940 bytes (940B) No change
ngx-meta-twitter-card.mjs 669 bytes (669B) 669 bytes (669B) No change
Total 7209 bytes (7.1KiB) 7327 bytes (7.2KiB) -1.61%: -118 bytes (-118B)

Copy link

📦 Bundle size (Angular v17)

Git ref: b62ead8

Module file Size Base size Difference
ngx-meta-core.mjs 2803 bytes (2.8KiB) 2913 bytes (2.9KiB) -3.77%: -110 bytes (-110B)
ngx-meta-json-ld.mjs 236 bytes (236B) 236 bytes (236B) No change
ngx-meta-open-graph.mjs 930 bytes (930B) 930 bytes (930B) No change
ngx-meta-routing.mjs 725 bytes (725B) 725 bytes (725B) No change
ngx-meta-standard.mjs 829 bytes (829B) 829 bytes (829B) No change
ngx-meta-twitter-card.mjs 515 bytes (515B) 515 bytes (515B) No change
Total 6038 bytes (5.9KiB) 6148 bytes (6.1KiB) -1.78%: -110 bytes (-110B)

Copy link

📦 Bundle size (Angular v15)

Git ref: b62ead8

Module file Size Base size Difference
ngx-meta-core.mjs 3054 bytes (3.0KiB) 3172 bytes (3.1KiB) -3.72%: -118 bytes (-118B)
ngx-meta-json-ld.mjs 402 bytes (402B) 402 bytes (402B) No change
ngx-meta-open-graph.mjs 1247 bytes (1.3KiB) 1247 bytes (1.3KiB) No change
ngx-meta-routing.mjs 897 bytes (897B) 897 bytes (897B) No change
ngx-meta-standard.mjs 940 bytes (940B) 940 bytes (940B) No change
ngx-meta-twitter-card.mjs 669 bytes (669B) 669 bytes (669B) No change
Total 7209 bytes (7.1KiB) 7327 bytes (7.2KiB) -1.61%: -118 bytes (-118B)

@davidlj95 davidlj95 merged commit 71e6b97 into main Jan 18, 2024
@davidlj95 davidlj95 deleted the stacked/perf-make-JSON-metadata-resolver-a-fn branch January 18, 2024 18:31
Copy link

🎉 This PR is included in version 1.0.0-alpha.33 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant