Skip to content

fix some typos #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 21, 2022
Merged

fix some typos #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e3291ed
apply https://github.com/day1co/tsconfig/pull/3
iolo Dec 13, 2022
858f66f
apply https://github.com/day1co/tsconfig/pull/2
iolo Dec 13, 2022
72a0ae6
revert #5
iolo Dec 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions tsconfig/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,16 @@
A base tsconfig for all typescript modules of [DAY1 COMPANY Inc.](https://day1company.co.kr)
based on [@tsconfig bases](https://github.com/tsconfig/bases).

Add the package to your `"devDependencies"`:
### Add the package to your `"devDependencies"`:

```sh
npm install --save-dev @day1co/tsconfig
npm install --save-dev @day1co/tsconfig @tsconfig/node-lts
```

Add to your `tsconfig.json`:
> NOTE: You should install `@tsconfig/node-lts` too!
> See https://github.com/microsoft/TypeScript/issues/18865

### Add to your `tsconfig.json`:

for Both Frontend and Backend:

Expand All @@ -26,9 +29,8 @@ for Backend:
for Backend using both Javascript and Typescript:

```json
"extends": "@day1co/tsconfig/backend-compat.json"
"extends": "@day1co/tsconfig/backend-mixed.json"
```

---

may the **SOURCE** be with you...
2 changes: 1 addition & 1 deletion tsconfig/backend.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"$schema": "https://json.schemastore.org/tsconfig",
"display": "@day1co/tsconfig/backend",
"extends": "@tsconfig/node16/tsconfig.json",
"extends": "@tsconfig/node-lts/tsconfig.json",
"compilerOptions": {
"allowUnreachableCode": false,
"noImplicitOverride": true,
Expand Down
2 changes: 1 addition & 1 deletion tsconfig/common.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"$schema": "https://json.schemastore.org/tsconfig",
"display": "@day1co/tsconfig/common",
"extends": "@tsconfig/node16/tsconfig.json",
"extends": "@tsconfig/node-lts/tsconfig.json",
"compilerOptions": {
"allowUnreachableCode": false,
"noImplicitOverride": true,
Expand Down
9 changes: 5 additions & 4 deletions tsconfig/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions tsconfig/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@day1co/tsconfig",
"version": "1.1.1",
"version": "1.1.2",
"author": "Day1Company",
"license": "MIT",
"repository": {
Expand All @@ -10,7 +10,7 @@
"publishConfig": {
"registry": "https://npm.pkg.github.com"
},
"dependencies": {
"devDependencies": {
"@tsconfig/node-lts": "^18.12.1"
}
}