Skip to content

refactor: guidelines 3.0 textfield style #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

annsch
Copy link
Collaborator

@annsch annsch commented Oct 12, 2022

  • add variants
  • add colors
  • add different states
  • remove unused styles

Additionally

  • docs/migrationGuide.adoc
  • Test-URLs: .pa11yci and tests/backstop.json

Comment on lines +102 to +110
/**
* used for input
**/
.box-with-border {
border: 1px solid rgba(0, 0, 0, 0.06);
padding: 0 1rem 1rem;
margin: 0 0 2rem;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a file provided by pattern lab – please move those declarations to source/css/pattern-scaffolding-project-specific.scss

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, thx :)

@mfranzke mfranzke added this to the Guidelines 3.0 milestone Oct 12, 2022
@annsch annsch changed the base branch from main to dbux-3 October 14, 2022 12:59
@annsch annsch changed the title Feat: textfield v3 refactor: Guidelines 3.0 textfield style Nov 1, 2022
@annsch annsch changed the title refactor: Guidelines 3.0 textfield style refactor: guidelines 3.0 textfield style Nov 1, 2022
@annsch annsch closed this Nov 24, 2022
@annsch annsch deleted the feat-textfield branch November 24, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants