Skip to content

refactor: replace slow performing CSS selectors #2968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

refactor: replace slow performing CSS selectors #2968

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
800600a
refactor: replaced by simpler solution
mfranzke Aug 3, 2024
e0eb738
test: updated screenshot
mfranzke Aug 5, 2024
dac6427
Merge branch 'main' into 2967-slow-performance-css-selectors
mfranzke Aug 5, 2024
eb92100
Merge branch 'main' into 2967-slow-performance-css-selectors
mfranzke Aug 5, 2024
ce524e4
Merge branch 'main' into 2967-slow-performance-css-selectors
mfranzke Aug 8, 2024
c651585
Merge branch 'main' into 2967-slow-performance-css-selectors
mfranzke Aug 9, 2024
a7633b6
Merge branch 'main' into 2967-slow-performance-css-selectors
mfranzke Aug 9, 2024
f5eaa2e
Update navigation.scss
mfranzke Aug 21, 2024
b8e6f06
Merge branch 'main' into 2967-slow-performance-css-selectors
mfranzke Aug 22, 2024
60e9d00
Merge branch 'main' into 2967-slow-performance-css-selectors
mfranzke Sep 14, 2024
3ecea1d
Merge branch 'main' into 2967-slow-performance-css-selectors
nmerget Dec 18, 2024
4f30e4e
Merge branch 'main' into 2967-slow-performance-css-selectors
mfranzke Jan 4, 2025
0bdd738
Merge branch 'main' into 2967-slow-performance-css-selectors
nmerget Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions packages/components/src/components/navigation/navigation.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,16 +86,6 @@
&[aria-current="page"],
&[data-active="true"] {
@extend %show-db-puls-auto;

menu {
// hide puls for non navigation items
:has([aria-current="page"]),
[aria-current="page"] {
&::after {
display: none;
}
}
}
}

// angular workaround: as no direct-child selector can be used, the pulse is hidden from the second level onwards
Expand Down
Loading