Skip to content

Fix artifact review checks hangs #11481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025
Merged

Fix artifact review checks hangs #11481

merged 1 commit into from
Apr 10, 2025

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Apr 10, 2025

Problem

The artifact review checks are hanging due to unexpected trigger ordering

Solution

Use a custom conclusion and set to neutral or success. never fail. Also add a PR comment to make the requirement more clear as to the expectations.

  • Update the branch protections to require this new job

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@emmyoop emmyoop requested a review from a team as a code owner April 10, 2025 13:00
@cla-bot cla-bot bot added the cla:yes label Apr 10, 2025
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.85%. Comparing base (e2e86b7) to head (5434b3f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11481      +/-   ##
==========================================
- Coverage   88.91%   88.85%   -0.07%     
==========================================
  Files         194      194              
  Lines       24553    24553              
==========================================
- Hits        21832    21817      -15     
- Misses       2721     2736      +15     
Flag Coverage Δ
integration 85.85% <ø> (-0.14%) ⬇️
unit 62.77% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.77% <ø> (+0.03%) ⬆️
Integration Tests 85.85% <ø> (-0.14%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@emmyoop emmyoop merged commit 7cca847 into main Apr 10, 2025
60 of 61 checks passed
@emmyoop emmyoop deleted the er/stop-hanging branch April 10, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants