Skip to content

remove ~= from dependency definitions #9640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 23, 2024
Merged

remove ~= from dependency definitions #9640

merged 5 commits into from
Feb 23, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Feb 23, 2024

resolves #9643

Problem

Solution

Replace ~= with >=,< for equivalent dependency definitions.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Feb 23, 2024
@emmyoop emmyoop added Skip Changelog Skips GHA to check for changelog file and removed cla:yes labels Feb 23, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@emmyoop emmyoop force-pushed the er/dependency-tweak branch from 0f54d8e to 9c896cd Compare February 23, 2024 14:31
@cla-bot cla-bot bot added the cla:yes label Feb 23, 2024
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.97%. Comparing base (7ea4670) to head (40fe7bb).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9640      +/-   ##
==========================================
- Coverage   88.00%   87.97%   -0.03%     
==========================================
  Files         176      177       +1     
  Lines       22311    22315       +4     
==========================================
- Hits        19634    19632       -2     
- Misses       2677     2683       +6     
Flag Coverage Δ
integration 85.57% <ø> (-0.03%) ⬇️
unit 62.07% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmyoop emmyoop marked this pull request as ready for review February 23, 2024 14:35
@emmyoop emmyoop requested a review from a team as a code owner February 23, 2024 14:35
@emmyoop emmyoop force-pushed the er/dependency-tweak branch from 1cfbba2 to c6d0d8f Compare February 23, 2024 15:09
@emmyoop emmyoop merged commit d1ebf9d into main Feb 23, 2024
@emmyoop emmyoop deleted the er/dependency-tweak branch February 23, 2024 19:35
@aranke aranke added backport 1.0.latest Tag for PR to be backported to the 1.0.latest branch backport 1.1.latest backport 1.2.latest This PR will be backported to the 1.2.latest branch backport 1.3.latest backport 1.4.latest backport 1.5.latest backport 1.6.latest labels Mar 4, 2024
Copy link
Contributor

github-actions bot commented Mar 4, 2024

The backport to 1.3.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3.latest 1.3.latest
# Navigate to the new working tree
cd .worktrees/backport-1.3.latest
# Create a new branch
git switch --create backport-9640-to-1.3.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d1ebf9d12a42d9bf0fa4e6d835c618979f3f83db
# Push it to GitHub
git push --set-upstream origin backport-9640-to-1.3.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3.latest

Then, create a pull request where the base branch is 1.3.latest and the compare/head branch is backport-9640-to-1.3.latest.

Copy link
Contributor

github-actions bot commented Mar 4, 2024

The backport to 1.2.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.2.latest 1.2.latest
# Navigate to the new working tree
cd .worktrees/backport-1.2.latest
# Create a new branch
git switch --create backport-9640-to-1.2.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d1ebf9d12a42d9bf0fa4e6d835c618979f3f83db
# Push it to GitHub
git push --set-upstream origin backport-9640-to-1.2.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.2.latest

Then, create a pull request where the base branch is 1.2.latest and the compare/head branch is backport-9640-to-1.2.latest.

Copy link
Contributor

github-actions bot commented Mar 4, 2024

The backport to 1.0.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.0.latest 1.0.latest
# Navigate to the new working tree
cd .worktrees/backport-1.0.latest
# Create a new branch
git switch --create backport-9640-to-1.0.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d1ebf9d12a42d9bf0fa4e6d835c618979f3f83db
# Push it to GitHub
git push --set-upstream origin backport-9640-to-1.0.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.0.latest

Then, create a pull request where the base branch is 1.0.latest and the compare/head branch is backport-9640-to-1.0.latest.

Copy link
Contributor

github-actions bot commented Mar 4, 2024

The backport to 1.1.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.1.latest 1.1.latest
# Navigate to the new working tree
cd .worktrees/backport-1.1.latest
# Create a new branch
git switch --create backport-9640-to-1.1.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d1ebf9d12a42d9bf0fa4e6d835c618979f3f83db
# Push it to GitHub
git push --set-upstream origin backport-9640-to-1.1.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.1.latest

Then, create a pull request where the base branch is 1.1.latest and the compare/head branch is backport-9640-to-1.1.latest.

Copy link
Contributor

github-actions bot commented Mar 4, 2024

The backport to 1.7.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.7.latest 1.7.latest
# Navigate to the new working tree
cd .worktrees/backport-1.7.latest
# Create a new branch
git switch --create backport-9640-to-1.7.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d1ebf9d12a42d9bf0fa4e6d835c618979f3f83db
# Push it to GitHub
git push --set-upstream origin backport-9640-to-1.7.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.7.latest

Then, create a pull request where the base branch is 1.7.latest and the compare/head branch is backport-9640-to-1.7.latest.

Copy link
Contributor

github-actions bot commented Mar 4, 2024

The backport to 1.4.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.4.latest 1.4.latest
# Navigate to the new working tree
cd .worktrees/backport-1.4.latest
# Create a new branch
git switch --create backport-9640-to-1.4.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d1ebf9d12a42d9bf0fa4e6d835c618979f3f83db
# Push it to GitHub
git push --set-upstream origin backport-9640-to-1.4.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.4.latest

Then, create a pull request where the base branch is 1.4.latest and the compare/head branch is backport-9640-to-1.4.latest.

Copy link
Contributor

github-actions bot commented Mar 4, 2024

The backport to 1.6.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.6.latest 1.6.latest
# Navigate to the new working tree
cd .worktrees/backport-1.6.latest
# Create a new branch
git switch --create backport-9640-to-1.6.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d1ebf9d12a42d9bf0fa4e6d835c618979f3f83db
# Push it to GitHub
git push --set-upstream origin backport-9640-to-1.6.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.6.latest

Then, create a pull request where the base branch is 1.6.latest and the compare/head branch is backport-9640-to-1.6.latest.

Copy link
Contributor

github-actions bot commented Mar 4, 2024

The backport to 1.5.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.5.latest 1.5.latest
# Navigate to the new working tree
cd .worktrees/backport-1.5.latest
# Create a new branch
git switch --create backport-9640-to-1.5.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d1ebf9d12a42d9bf0fa4e6d835c618979f3f83db
# Push it to GitHub
git push --set-upstream origin backport-9640-to-1.5.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.5.latest

Then, create a pull request where the base branch is 1.5.latest and the compare/head branch is backport-9640-to-1.5.latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.0.latest Tag for PR to be backported to the 1.0.latest branch backport 1.1.latest backport 1.2.latest This PR will be backported to the 1.2.latest branch backport 1.3.latest backport 1.4.latest backport 1.5.latest backport 1.6.latest backport 1.7.latest cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize Dependency Definitions
4 participants