-
Notifications
You must be signed in to change notification settings - Fork 101
Allow custom events URL via GITHUB_EVENTS_URL. #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
`<small>` doesn't work so I've used repeated `<sub><sup>` elements so that the text font is really tiny. [1] Tested in different ways so that the lack of closing sub/sup tags doesn't mess up with the next lines of text. [1] http://meta.stackexchange.com/a/107111
Hide easter egg in plain sight 😈
optimize png images using zopflipng
use minified odometer.js on CDNJS to benefit from http/2
Add a feature to filter out events of specified repos/orgs
Allow fetching custom events, by setting the `GITHUB_EVENTS_URL` environment variable. The value of `GITHUB_EVENTS_URL` can be anyone of the URLs listed [here](https://developer.github.com/v3/activity/events/). Also added port to socketio initialization to fix local development.
app/public/js/main.js
Outdated
@@ -32,7 +32,8 @@ var svg_background_color_online = '#0288D1', | |||
|
|||
|
|||
|
|||
var socket = io(document.location.hostname); | |||
var socketHost = document.location.hostname + ":" + document.location.port; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've fixed this on my end, using just document.location.host
which includes the port: 75451ca.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kewl, will revert this change
Hey @erikzaadi thanks for the PR! Could you please fix the merge conflict, it's a small one. |
@debugger22 you can check out the PR yourself and do the rebase. |
Would this close #26? We think it might. |
872e658
to
e5d1bb7
Compare
Allow fetching custom events, by setting the
GITHUB_EVENTS_URL
environment variable.The value of
GITHUB_EVENTS_URL
can be anyone of the URLs listed here.Also added Gravatar support