Skip to content

feat: add run_async for CohereChatGenerator #1689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: add run_async for CohereChatGenerator #1689

wants to merge 4 commits into from

Conversation

Ryzhtus
Copy link
Contributor

@Ryzhtus Ryzhtus commented May 2, 2025

Related Issues

Proposed Changes:

  • Introduced async support in CohereChatGenerator via a new run_async method
  • Added async test coverage and included pytest-asyncio as a test dependency

How did you test it?

I added async versions for tests in test_cohere_chat_generator.py

Notes for the reviewer

I've also test live methods with my own API key, but feel free to test yourself

Checklist

@Ryzhtus Ryzhtus requested a review from a team as a code owner May 2, 2025 11:08
@Ryzhtus Ryzhtus requested review from anakin87 and removed request for a team May 2, 2025 11:08
@github-actions github-actions bot added the type:documentation Improvements or additions to documentation label May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anakin87 anakin87 Awaiting requested review from anakin87 anakin87 is a code owner automatically assigned from deepset-ai/open-source-engineering

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
integration:cohere type:documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add run_async for CohereChatGenerator
1 participant
@Ryzhtus