Skip to content

Moiz-Bot 2787-Account switcher fixes on Dbot #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

moiz-deriv
Copy link
Contributor

Moved account switcher divider generation to inner loop where account tabs are being generated.
Before changes:
Account divider would always be rendered even when only one account is present
After Changes:
Account divider will only be rendered if the user has more than one account

}}
/>
</span>
{modifiedCRAccountList.length > 0 && <AccountSwitcherDivider />}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{modifiedCRAccountList.length > 0 && <AccountSwitcherDivider />}
{modifiedCRAccountList.length && <AccountSwitcherDivider />}

/>
</span>
<>
{' '}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove this?

Copy link

github-actions bot commented May 6, 2025

Name Result
Build status Failed ❌
Action URL Visit Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants