Skip to content

Add The Nefarious Developer devcontainers to index #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: gh-pages
Choose a base branch
from

Conversation

NickChecan
Copy link

What type of PR is this?

  • Add a new dev container collection
  • Update to an existing dev container collection
  • Documentation/spec update
  • Other containers.dev site update (UX, layout, etc)

Related Issues

  • Related Issue #
  • Closes #

Description

Add devcontainer templates from the org The Nefarious Developer to the index.

Collection checklist

If your PR contributes a new collection, please utilize this checklist:

  • Collection name
  • Maintainer name
  • Maintainer contact link (i.e. link to a GitHub repo, email)
  • Repository URL
  • OCI Reference
  • I acknowledge that this collection provides new functionality, distinct from the existing collections part of this index.

@NickChecan NickChecan requested a review from a team as a code owner October 19, 2024 03:39
@Kaniska244
Copy link

Hi @NickChecan ,

Thank you for the PR. The ORAS spec requires the ociReference to be in lower case. Would you kindly update the same.
The supporting tools do help convert the case, however, its better to sync as much as possible.

With Regards,
Kaniska

Change request by @Kaniska244 to avoid issues with the ORAS spec
@NickChecan
Copy link
Author

Hi @NickChecan ,

Thank you for the PR. The ORAS spec requires the ociReference to be in lower case. Would you kindly update the same. The supporting tools do help convert the case, however, its better to sync as much as possible.

With Regards, Kaniska

No problem at all @Kaniska244 . Thanks for the analysis and feedback. I made the change as requested. Let me know if anything else is needed from my side.

@Kaniska244
Copy link

Change approved. This can be merged.

eljog
eljog previously approved these changes Feb 24, 2025
Copy link
Member

@eljog eljog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR
Please resolve conflicts

@NickChecan
Copy link
Author

@Kaniska244 and @eljog conflicts were resolved. Can you please approve so it can be merged?
Thanks in advance.

@NickChecan NickChecan requested a review from eljog February 26, 2025 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants