-
Notifications
You must be signed in to change notification settings - Fork 294
Add dotnet-node #521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dotnet-node #521
Conversation
Hi @sebdanielsson , Thanks for the PR. Would you kindly modify the main Readme file (https://github.com/sebdanielsson/devcontainers/blob/main/README.md) of the repo with relevant details. With Regards, |
Thanks for the review! Should be fixed now👍 Sebastian |
Change approved. This can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! After the merge conflicts are fixed we can get this added in ⚡
8f6585a
to
f706e5c
Compare
Just rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! Sorry, but you'll have to fix the merge conflicts again
No problems. That was messy. Closed in favor of #544 |
What type of PR is this?
Description
This PR adds a devcontainer for developing web apps using dotnet for the backend and Node.js for the frontend.
Collection checklist
If your PR contributes a new collection, please utilize this checklist: