-
Notifications
You must be signed in to change notification settings - Fork 448
[terraform] Add Custom Download Server Support for Terraform Dev Container Feature #1364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AlvaroRausell
merged 9 commits into
devcontainers:main
from
iTiPo:custom-server-to-download-terraform
Jun 3, 2025
Merged
[terraform] Add Custom Download Server Support for Terraform Dev Container Feature #1364
AlvaroRausell
merged 9 commits into
devcontainers:main
from
iTiPo:custom-server-to-download-terraform
Jun 3, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uire full URL with protocol
4f13686
to
7f654ca
Compare
@microsoft-github-policy-service agree |
Kaniska244
approved these changes
May 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are fine & test scenarios validated. To be further reviewed by maintainers.
@Kaniska244 can you tell me approximately how long I need to wait for maintainers? Maybe I should write to someone asking them to view this PR? |
AlvaroRausell
requested changes
May 30, 2025
…nt newline handling and invoking reportResults function.
54ca018
to
2e9c1d2
Compare
AlvaroRausell
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the ability to specify a custom download server for the Terraform Dev Container feature. This enhancement is particularly useful for organizations that maintain internal mirrors or have proxies for HashiCorp downloads, allowing them to control the source of Terraform and Sentinel packages.
Key Changes:
customDownloadServer
in thedevcontainer-feature.json
to allow users to specify an alternative server URL.install.sh
script to utilize the custom server URL when provided, ensuring that the download process respects the user's configuration.NOTES.md
to include guidelines on using the custom download server, along with security considerations to ensure users are aware of potential risks.Motivation:
Testing:
scenarios.json
to include cases for custom download server usage, ensuring that the feature works as expected with different configurations.