-
Notifications
You must be signed in to change notification settings - Fork 149
Add account delegation preparation #3076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+577
−301
Merged
Changes from all commits
Commits
Show all changes
80 commits
Select commit
Hold shift + click to select a range
80c98c2
add get_accounts_for_origin to account_management and get_accounts to…
LXIF daf7c2f
add authorization fn
LXIF 5fb5bc1
clippy
LXIF c25a7bb
add tests for get and create
LXIF e5f72b3
clippy
LXIF 07d0f73
add account updating endpoint and related account management function…
LXIF b98bc18
cwippy
LXIF 55f85d9
add seed_from_anchor to Account
LXIF 5a4c704
add seed_from_anchor to account struct
LXIF af693d0
add calculate_account_delegation_seed function
LXIF f10ac25
make get_accounts return a result
LXIF a281016
Merge branch 'andri/implement-get-accounts' into andri/implement-crea…
LXIF d75a785
add principal to GetAccountsError::Unauthorized
LXIF 9110107
Merge branch 'andri/implement-get-accounts' into andri/implement-crea…
LXIF 4355c14
add const
LXIF fe51d28
add global acc limit and unit test
LXIF c80561c
Merge branch 'andri/implement-create-account' into andri/implement-up…
LXIF dc5863d
add max acc limit to update function
LXIF a3c9501
add authorization, add checking if anchor has account (for later)
LXIF fa38325
merge main
LXIF 674bbb0
clippy
LXIF 72a3294
fix did
LXIF 893d1f5
Merge branch 'andri/implement-create-account' into andri/implement-up…
LXIF 6cefda2
add per-acc auth check in account management
LXIF a74c252
add tests, restructure per-acc auth check in update_account
LXIF 81c6521
change variant name, update comment
LXIF da58a36
cleanup function inputs
LXIF 206b259
merge main
LXIF 037c9e8
cwippy
LXIF 5e5687d
cwippy again
LXIF 649bd83
Merge branch 'andri/implement-update-account' into andri/implement-cr…
LXIF eca0ed5
minor changes
LXIF 8de7852
add account delegation preparation function and update endpoint
LXIF 62e4012
fix did
LXIF a46738b
fix did
LXIF 9e555c2
cwippy
LXIF 482e80a
fix did again
LXIF 845308f
cwippy fix
LXIF 42999ec
fix did?
LXIF 9f48cf6
fix typing
LXIF e76cc72
clippyyy
LXIF 2eb418f
Merge branch 'main' into andri/implement-create-account-delegation
LXIF f0f7089
cleanup
LXIF 2880261
clippy
LXIF ebb0bac
fix read_account method to account for seed_from_anchor
LXIF 6785d65
Merge branch 'main' into andri/implement-create-account-delegation
LXIF 7c29d5d
rename
LXIF 3d38247
move seed generation function into account impl
LXIF 418865c
clippy
LXIF 7d45b64
cleanup delegation generation, handle default account in has_account_…
LXIF 340a488
return account from anchor_has_account
LXIF 90e4a34
Merge branch 'main' into andri/implement-create-account-delegation
LXIF 4fab02b
cleanupt
LXIF 536a80c
restructure has_account_reference and anchor_has_account
LXIF ec29af8
cwippy
LXIF b3bead0
Merge branch 'main' into andri/implement-create-account-delegation
LXIF 4bc169b
return default acc if no application number
LXIF adc1ca5
cwippy
LXIF fd26acc
cleanup
LXIF f75d321
restructure storage borrowing
LXIF 381d5a7
make nicer
LXIF cad122e
update list_accounts to return accounts and use read_account
LXIF 068f900
remove anchor_has_account, pack everything into read_account
LXIF ffbfa93
clippy
LXIF f23c061
clippy
LXIF ed07dc1
add comment
LXIF c27bbc3
clippy
LXIF fa0773d
change error type
LXIF db7d1ed
Merge branch 'main' into andri/implement-create-account-delegation
LXIF 591c28b
fix function inputs
LXIF 19e0299
fix tests
LXIF 52e5349
🤖 cargo-fmt auto-update
github-actions[bot] 3788ba7
add tests, rename some things
LXIF a64e846
Merge branch 'main' into andri/implement-create-account-delegation
LXIF c7fc663
remove comment
LXIF ec0af93
update comments
LXIF f1a27d3
add expect message, add comments
LXIF 5b7e04a
clippy
LXIF acd0dea
update match statement in calculate_seed
LXIF fe6baa1
Merge branch 'main' into andri/implement-create-account-delegation
LXIF File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that you need to manually recreate the types. The task that used to do it got broken somehow, which we should think whether we want to fix or remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what you mean by that - which types do I need to recreate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you change the candid file, we must also change the Typescript related files by running
npm run generate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh right, doing that