Add get_account_delegation functionality #3078
Merged
+109
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… main, update existing code
…s as well as tests
…te-account merge get_accounts return result
…te-account Update error handling
…mplement-retrieve-account-delegation merge dependency branch
lmuntaner
reviewed
May 19, 2025
That's the gist, yes. |
* add get_accounts_for_origin to account_management and get_accounts to main, update existing code * add authorization fn * clippy * add tests for get and create * clippy * add account updating endpoint and related account management functions as well as tests * cwippy * add seed_from_anchor to Account * add seed_from_anchor to account struct * add calculate_account_delegation_seed function * make get_accounts return a result * add principal to GetAccountsError::Unauthorized * add const * add global acc limit and unit test * add max acc limit to update function * add authorization, add checking if anchor has account (for later) * clippy * fix did * add per-acc auth check in account management * add tests, restructure per-acc auth check in update_account * change variant name, update comment * cleanup function inputs * cwippy * cwippy again * minor changes * add account delegation preparation function and update endpoint * fix did * fix did * cwippy * fix did again * cwippy fix * fix did? * fix typing * clippyyy * cleanup * clippy * fix read_account method to account for seed_from_anchor * rename * move seed generation function into account impl * clippy * cleanup delegation generation, handle default account in has_account_reference, move anchor_has_account * return account from anchor_has_account * cleanupt * restructure has_account_reference and anchor_has_account * cwippy * return default acc if no application number * cwippy * cleanup * restructure storage borrowing * make nicer * update list_accounts to return accounts and use read_account * remove anchor_has_account, pack everything into read_account * clippy * clippy * add comment * clippy * change error type * fix function inputs * fix tests * 🤖 cargo-fmt auto-update * add tests, rename some things * remove comment * update comments * add expect message, add comments * clippy * update match statement in calculate_seed --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
* Improve copy in buttons * Revert changes in use another account
lmuntaner
reviewed
May 20, 2025
There was a problem hiding this comment.
Will you also recreate the TS types?
There was a problem hiding this comment.
@lmuntaner I had to disable the interface tests already for the other PRs because some dummy endpoints did not return Result.
There was a problem hiding this comment.
Can we enable them now?
There was a problem hiding this comment.
The PR is already up, but it fails because it apparently compares to the interface of the last release - which would mean we can only re-enable it once we have released.
There was a problem hiding this comment.
@lmuntaner should be able to force that PR.
There was a problem hiding this comment.
Shouldn't it pass once this PR is merged?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In order to authenticate, we need to retrieve the account delegation we prepared. NOTE: This PR branches off of #3076 - that PR should probably be reviewed and merged before this one.
Changes
Add
get_account_delegationquery method, addget_account_delegationfunction in account_management.rs, removeget_delegationin delegation.rs and replace it withget_account_delegationin theget_delegationendpoint.Tests
No new tests were added, integration tests for account delegations are in Jira and will be implemented asap. However, as legacy functions have been replaced, there is some amount of test coverage already.