feat: try revert "safe test" transitions directives #6404
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Dal Busco <[email protected]>
Signed-off-by: David Dal Busco <[email protected]>
Signed-off-by: David Dal Busco <[email protected]>
This was referenced Feb 12, 2025
|
PR use for testing purpose. Mocking configuration will be manually applied to the Svelte v5 branch once all revert PRs of "testSafe..." directives have been applied. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 12, 2025
# Motivation Revert #6396 because thanks to a different way of mocking the transitions for test purposes (without vite), those workaround are not needed anymore when migrating to Svelte v5. # Resources New solution to mock the animation for test purposes with Svelte v5 providing by Testing Library in testing-library/svelte-testing-library#284 (comment) # Changes Revert #6396 # Tests I tested the revert and new way of mocking with Svelte v5 in #6404. The tests did not throw the keyword `TypeError: Cannot set properties of undefined (setting 'onfinish')`. Signed-off-by: David Dal Busco <[email protected]>
peterpeterparker
added a commit
to dfinity/gix-components
that referenced
this pull request
Feb 12, 2025
# Motivation Revert #574 because thanks to a different way of mocking the transitions for test purposes (without vite), those workaround are not needed anymore. # Resources - Mock tested in dfinity/nns-dapp#6404 - New solution to mock the animation for test purposes with Svelte v5 providing by Testing Library in testing-library/svelte-testing-library#284 (comment) # Changes - Revert #574 and use Svelte transitions --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We revert the "testSafeXXX" transitions to resolve the issue we were facing while migrating to Svelte v5 with the new suggestion provided on Testing Library repo: testing-library/svelte-testing-library#284 (comment)
This branch is meant to assert that the error
TypeError: Cannot set properties of undefined (setting 'onfinish')is not thrown anymore for Svelte v5 with the new way of mocking "animate" prototype.