feat: move request and response hashing from ic-response-verification to ic-http-certification #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanosdev
commented
Dec 5, 2023
packages/ic-response-verification/src/verification/verify_request_response_pair.rs
Show resolved
Hide resolved
nathanosdev
force-pushed
the
nathan/use-cel-builder-integration-tests
branch
from
6df5d3a to
05a527f
Compare
nathanosdev
force-pushed
the
nathan/move-request-response-hashing
branch
from
9285193 to
0521294
Compare
nathanosdev
changed the base branch from
nathan/use-cel-builder-integration-tests
to
main
nathanosdev
commented
Dec 7, 2023
packages/ic-response-verification/tests/v2_response_verification_certification_scenarios.rs
Show resolved
Hide resolved
… to ic-http-certification BREAKING CHANGE:
nathanosdev
force-pushed
the
nathan/move-request-response-hashing
branch
from
0521294 to
d4a5506
Compare
keplervital
reviewed
Dec 8, 2023
keplervital
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the PR I've been trying to split to make smaller, finally 😄
This was originally meant to be two, but I had a nightmare splitting them.