Skip to content

feat: move request and response hashing from ic-response-verification to ic-http-certification #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

nathanosdev
Copy link
Member

@nathanosdev nathanosdev commented Dec 5, 2023

This is the PR I've been trying to split to make smaller, finally 😄

This was originally meant to be two, but I had a nightmare splitting them.

@nathanosdev nathanosdev self-assigned this Dec 5, 2023
@nathanosdev nathanosdev force-pushed the nathan/use-cel-builder-integration-tests branch from 6df5d3a to 05a527f Compare December 5, 2023 14:33
@nathanosdev nathanosdev force-pushed the nathan/move-request-response-hashing branch from 9285193 to 0521294 Compare December 5, 2023 16:53
@nathanosdev nathanosdev changed the base branch from nathan/use-cel-builder-integration-tests to main December 7, 2023 10:04
@nathanosdev nathanosdev force-pushed the nathan/move-request-response-hashing branch from 0521294 to d4a5506 Compare December 7, 2023 10:08
@nathanosdev nathanosdev marked this pull request as ready for review December 7, 2023 10:17
@nathanosdev nathanosdev requested a review from a team as a code owner December 7, 2023 10:17
@nathanosdev nathanosdev merged commit c1a92a8 into main Dec 8, 2023
@nathanosdev nathanosdev deleted the nathan/move-request-response-hashing branch December 8, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants