Skip to content

C library: add __to{lower,upper} as alternative names for {tolower,toupper} #8283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2024

Conversation

tautschnig
Copy link
Collaborator

macOS eventually calls a function called __tolower (__toupper). Rename our previous implementation to __CPROVER_tolower (__CPROVER_toupper) and make both tolower (toupper) and __tolower (__toupper) use this. Also enable their regression tests.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

…upper}

macOS eventually calls a function called `__tolower` (`__toupper`).
Rename our previous implementation to `__CPROVER_tolower`
(`__CPROVER_toupper`) and make both `tolower` (`toupper`) and
`__tolower` (`__toupper`)  use this. Also enable their regression tests.
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.55%. Comparing base (f18b509) to head (98d09fb).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8283   +/-   ##
========================================
  Coverage    77.55%   77.55%           
========================================
  Files         1721     1721           
  Lines       190128   190128           
  Branches     18438    18438           
========================================
  Hits        147448   147448           
  Misses       42680    42680           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kroening kroening merged commit 0889cfa into diffblue:develop May 10, 2024
40 checks passed
@tautschnig tautschnig deleted the features/tolower branch May 10, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants