Skip to content

Undefined shifts are now fatal #8304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Undefined shifts are now fatal #8304

merged 1 commit into from
Jun 12, 2024

Conversation

kroening
Copy link
Member

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@kroening kroening added C++ Front End C Front End soundness Soundness bug? Review and add "aws" if it is, or remove "soundness" if it isn't. labels May 26, 2024
@kroening kroening changed the title Undefined shift fatal Undefined shifts are now fatal May 26, 2024
@kroening kroening marked this pull request as ready for review May 26, 2024 15:20
Copy link

codecov bot commented May 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.29%. Comparing base (621fe05) to head (c70148e).

Files Patch % Lines
src/ansi-c/goto-conversion/goto_check_c.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8304   +/-   ##
========================================
  Coverage    78.29%   78.29%           
========================================
  Files         1722     1722           
  Lines       188448   188448           
  Branches     18452    18452           
========================================
+ Hits        147540   147544    +4     
+ Misses       40908    40904    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig
Copy link
Collaborator

Needs a rebase.

There are various criteria for shift expressions that render them undefined
behavior.  The corresponding assertions are now fatal.
@kroening kroening force-pushed the undefined-shift-fatal branch from de3f0a1 to c70148e Compare June 5, 2024 12:59
@kroening kroening assigned tautschnig and unassigned kroening Jun 5, 2024
@tautschnig tautschnig merged commit d6150ce into develop Jun 12, 2024
39 of 41 checks passed
@tautschnig tautschnig deleted the undefined-shift-fatal branch June 12, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ Front End C Front End soundness Soundness bug? Review and add "aws" if it is, or remove "soundness" if it isn't.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants