Skip to content

pointer checks are now fatal #8316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Conversation

kroening
Copy link
Member

@kroening kroening commented Jun 5, 2024

The checks for

  • pointer dereferences
  • pointer relations
  • pointer arithmetic

are designed to identify cases of undefined behavior. They must be fatal.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@kroening kroening added C++ Front End C Front End soundness Soundness bug? Review and add "aws" if it is, or remove "soundness" if it isn't. labels Jun 5, 2024
@kroening kroening force-pushed the pointer-dereference-is-now-fatal branch 2 times, most recently from 7ad5757 to b50d65f Compare June 5, 2024 16:10
@kroening kroening marked this pull request as ready for review June 5, 2024 16:19
@kroening kroening force-pushed the pointer-dereference-is-now-fatal branch 3 times, most recently from de97cfa to d884de5 Compare June 9, 2024 20:45
Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving of the overall approach, but more test specs need to be updated (more UNKNOWN properties).

@tautschnig tautschnig added the Version 6 Pull requests and issues requiring a major version bump label Jun 13, 2024
@kroening kroening force-pushed the pointer-dereference-is-now-fatal branch 2 times, most recently from 9cd59ae to 6c033f0 Compare June 14, 2024 01:13
The checks for

* pointer dereferences
* pointer relations
* pointer arithmetic

are designed to identify cases of undefined behavior.  They must be fatal.
@kroening kroening force-pushed the pointer-dereference-is-now-fatal branch from 6c033f0 to 2c19fb9 Compare June 14, 2024 01:29
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.34%. Comparing base (ed51462) to head (2c19fb9).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8316      +/-   ##
===========================================
- Coverage    78.34%   78.34%   -0.01%     
===========================================
  Files         1722     1722              
  Lines       188369   188369              
  Branches     18456    18454       -2     
===========================================
- Hits        147572   147569       -3     
- Misses       40797    40800       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig tautschnig merged commit 780b687 into develop Jun 14, 2024
41 checks passed
@tautschnig tautschnig deleted the pointer-dereference-is-now-fatal branch June 14, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ Front End C Front End soundness Soundness bug? Review and add "aws" if it is, or remove "soundness" if it isn't. Version 6 Pull requests and issues requiring a major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants