FEATURE: Add success label to (sidekiq|scheduled)_job_count
#137
+90
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgxworld
force-pushed
the
implement_sidekiq_job_error_count
branch
from
6fa8460 to
e0db1b3
Compare
Before this commit, `scheduled_job_count` represents the total number of scheduled jobs executed regardless of its execution status while `sidekiq_job_count` represents the total number of sidekiq job executed successfuly only. In order to allow the error rate for a particular job, we need to be able to differentiate between successes and failures. This commit seeks to do so by adding a `success` label to the `sidekiq_job_count` and `scheduled_job_count` counters.
tgxworld
force-pushed
the
implement_sidekiq_job_error_count
branch
from
e0db1b3 to
1bc8099
Compare
tgxworld
changed the title
sidekiq_job_error_count counter metricsuccess label to (sidekiq|scheduled)_job_count
nattsw
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit,
scheduled_job_countrepresents the total number ofscheduled jobs executed regardless of its execution status while
sidekiq_job_countrepresents the total number of sidekiq job executedsuccessfuly only.
In order to allow the error rate for a particular job, we need to be
able to differentiate between successes and failures. This commit
seeks to do so by adding a
successlabel to thesidekiq_job_countand
scheduled_job_countcounters.Requires discourse/discourse#32307