Help text for foundation Meeting model fields #1945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi and thanks for opening this PR! 🎸 I've tagged our current secretary as a reviewer to get an opinion on the wording since those changes are mostly for their benefit I believe. Note also that the automated tests are currently failing, it seems it's because you didn't include the missing migration files for the |
|
The wording seems alright to me. One thing, I'm not too sure if https://www.djangoproject.com/styleguide/content/ is kept up to date, but Thibaud seemed to think it was good enough so it's probably better than nothing. I'll defer to others but I'm also not sure how we feel about having style elements in HTML (if we hope to use CSP some day) or having colours without using CSS variables. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1464
