Skip to content

don't use @trusted functions nested in @safe functions #3077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

don't use @trusted functions nested in @safe functions #3077

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions spec/function.dd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3329,6 +3329,16 @@ $(H3 $(LNAME2 trusted-functions, Trusted Functions))
that they are easier to manually verify.
)

$(BEST_PRACTICE Do not use `@trusted` nested functions in order to introduce
unsafe code into `@safe` code. Such functions tend to hide their presence
inside `@safe` code. Nested functions can manipulate variables in their
caller's scope leading to difficulty in manually verifying that it has an
`@safe` interface.
Instead, `@trusted` functions should be non-nested with a carefully designed
`@safe` interface.
`@trusted` nested functions may be deprecated in the future.
)

$(H3 $(LNAME2 system-functions, System Functions))

$(P System functions are functions not marked with $(CODE @safe) or
Expand Down