-
-
Notifications
You must be signed in to change notification settings - Fork 740
Move std.typecons.apply to std.experimental #6389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#6389" |
Seems reasonable, since it has to be freestanding anyways. Needs an import there, ofc. :) |
I'd be more on board with this if we had a process of when to move it to stable typecons. wrap has been sitting there for a while. |
I think this is function is simple enough that it does not need a stabilization period, but I'm on board either way. |
Yeah, but wasn't it that the new Anyhow, we can also simply add a warning to the docs if that's easier for everyone. or an orange message box with background as added here:
I agree, but you got to start somewhere and I have being saying this for a while now and this was the first function that got added - and in this case just because Jack was so upset with how slowly things are moving and "stuck out his neck". Not that I'm against this rescue of this PR, it's just that this shouldn't be the normal case on how we merge new symbols and without an experimental stage of some sort such PRs are never merged. |
055d33a
to
168eb65
Compare
My condition for approving this there needs to be, explicitly stated in the docs, a period when this will be moved out of experimental and into std (baring excessive bugs of course). Honestly, there should be an inverse of my deprecation process DIP, i.e. a DIP for defining a process of moving experimental functions to mainline after N releases. |
I guess it's too late for this now :/ |
Introduced in #6182
Just going to make a move here with one approach. May the nitpicking for the best solution begin ;-)