Followup to addition of apply #6390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
andralex
commented
Mar 30, 2018
andralex
commented
- inline code words easiest as backticks
- prefer https to http
- apply should not be "opinionated" about value vs reference, just transparently pass arguments through
* inline code words easiest as backticks * prefer https to http * apply should not be "opinionated" about value vs reference, just transparently pass arguments through
|
Thanks for your pull request, @andralex! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#6390" |
|
see also #6182 |
|
CI shouldn't fail... cc @MartinNowak |
|
Windows failure: braddr/d-tester#71 The segfault when building dub is a "new" one. |
wilzbach
approved these changes
Mar 30, 2018
| When called on a $(D Nullable), $(D apply) will unpack the value contained in the $(D Nullable), | ||
| pass it to the function you provide and wrap the result in another $(D Nullable) (if necessary). | ||
| If the Nullable is null, $(D apply) will return null itself. | ||
| When called on a `Nullable`, `apply` will unpack the value contained in the `Nullable`, |
|
Fix for the Project Tester incoming -> dlang/ci#189 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.