Skip to content

Private property should start with underscore“ #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2020
Merged

Private property should start with underscore“ #103

merged 1 commit into from
Mar 24, 2020

Conversation

928PJY
Copy link
Collaborator

@928PJY 928PJY commented Mar 23, 2020

#78

@928PJY 928PJY requested a review from mingwli March 23, 2020 07:42
@codecov-io
Copy link

Codecov Report

Merging #103 into master will decrease coverage by 0.08%.
The diff coverage is 88.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
- Coverage      88%   87.92%   -0.09%     
==========================================
  Files          29       29              
  Lines        1009     1010       +1     
  Branches       90       90              
==========================================
  Hits          888      888              
- Misses         97       98       +1     
  Partials       24       24
Flag Coverage Δ
#unit 87.92% <88.32%> (-0.09%) ⬇️
Impacted Files Coverage Δ
src/observers/docsLoggerObserver.ts 98.62% <100%> (ø) ⬆️
src/observers/docsOutputChannelObserver.ts 100% <100%> (ø) ⬆️
src/observers/signStatusBarObserver.ts 90.47% <100%> (ø) ⬆️
src/common/platformInformation.ts 32% <50%> (ø) ⬆️
src/observers/baseStatusBarObserver.ts 58.33% <54.54%> (ø) ⬆️
src/credential/keyChain.ts 73.68% <83.33%> (ø) ⬆️
src/build/buildController.ts 95.29% <91.17%> (-1.14%) ⬇️
src/build/buildExecutor.ts 95.77% <91.66%> (ø) ⬆️
src/observers/telemetryObserver.ts 92.47% <94.73%> (ø) ⬆️
src/credential/credentialController.ts 92.47% <96%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fcc7f1...3315aba. Read the comment docs.

@928PJY 928PJY merged commit 702caf2 into docascode:master Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants