-
Notifications
You must be signed in to change notification settings - Fork 7.6k
feat: support running vale locally #22130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mdelapenya
wants to merge
4
commits into
docker:main
Choose a base branch
from
mdelapenya:makefile-vale
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+30
−0
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
973a4a2
chore: add a make goal to run the validations
mdelapenya 181090e
feat: add a make goal to run vale locally
mdelapenya cb4c1b6
Revert "chore: add a make goal to run the validations"
mdelapenya bce89cf
Merge branch 'main' into makefile-vale
mdelapenya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,18 @@ | ||
# Directory containing the content to validate. Default is "content". | ||
# It can be overridden by setting the CONTENT_DIR environment variable. | ||
# Example: CONTENT_DIR=content/manuals/compose make vale | ||
CONTENT_DIR := $(or $(CONTENT_DIR), content) | ||
|
||
# Docker image to use for vale. | ||
VALE_IMAGE := jdkato/vale:latest | ||
|
||
.PHONY: vale | ||
vale: ## run vale | ||
docker run --rm -v $(PWD):/docs \ | ||
-w /docs \ | ||
-e PIP_BREAK_SYSTEM_PACKAGES=1 \ | ||
$(VALE_IMAGE) $(CONTENT_DIR) | ||
|
||
.PHONY: vendor | ||
vendor: ## vendor hugo modules | ||
./hack/vendor |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering if we could have it running within our Dockerfile so it could be used with bake like
lint
:docs/docker-bake.hcl
Lines 48 to 52 in 9623874
docs/Dockerfile
Lines 53 to 60 in 9623874
Then we could just add a
vale
bake target tovalidate
group?docs/docker-bake.hcl
Lines 38 to 40 in 9623874
And would probably be able to remove this ci job
docs/.github/workflows/build.yml
Lines 77 to 86 in 9623874
And just add
vale
to this matrixdocs/.github/workflows/build.yml
Lines 93 to 99 in 9623874
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still need to create a foundational knowledge on bake, but it seems reasonable to include the target as part of the current build system. I'd go with what you suggest