admin-settings: add note regarding KinD + ECI config. #22435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctalledo
requested review from
aevesdocker and
sarahsanders-docker
as code owners
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ctalledo
force-pushed
the
kind-eci
branch
2 times, most recently
from
8bd6546 to
55675b8
Compare
In the admin-settings docs, in the section that describes settings for Docker Desktop Kubernetes, add a note indicating that if a custom repository is used for Kubernetes node images, and if Enhanced Container Isolation (ECI) is enabled, the custom repository images must also be added to the ECI Docker Socket image list setting. Signed-off-by: Cesar Talledo <[email protected]>
content/manuals/security/for-admins/hardened-desktop/settings-management/configure-json-file.md
Show resolved
Hide resolved
content/manuals/security/for-admins/hardened-desktop/settings-management/configure-json-file.md
Outdated
Show resolved
Hide resolved
sarahsanders-docker
requested changes
Apr 15, 2025
Co-authored-by: Sarah Sanders <[email protected]>
Thanks for the quick review @sarahsanders-docker, I've updated the PR based on your suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the admin-settings docs, in the section that describes settings for Docker Desktop Kubernetes, add a note indicating that if a custom repository is used for Kubernetes node images, and if Enhanced Container Isolation (ECI) is enabled, the custom repository images must also be added to the ECI Docker Socket image list setting.
Related issues or tickets
https://docker.atlassian.net/browse/POS-2924
https://docker.atlassian.net/browse/SEG-1102
Reviews