Skip to content

feat: Add Right-to-Left (RTL) layout support #2551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions docs/configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -776,6 +776,19 @@ without the `#` in the URL and SEO optimization.
> };
> ```

## rtl

- Type: `Boolean`
- Default: `false`

Enables Right-to-Left (RTL) layout for the documentation. When set to `true`, the sidebar will appear on the right, text will be aligned to the right, and the overall layout will be mirrored for RTL languages.

```js
window.$docsify = {
rtl: true,
};
```

## routes

- Type: `Object`
Expand Down
5 changes: 5 additions & 0 deletions src/core/Docsify.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,11 @@ export class Docsify extends Fetch(
this.initRender(); // Render base DOM
this.initEvent(); // Bind events
this.initFetch(); // Fetch data

if (this.config.rtl) {
document.body.classList.add('rtl');
}

this.callHook('mounted');
}

Expand Down
1 change: 1 addition & 0 deletions src/core/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ export default function (vm) {
repo: '',
routes: {},
routerMode: 'hash',
rtl: false,
subMaxLevel: 0,
// themeColor: '',
topMargin: 0,
Expand Down
1 change: 1 addition & 0 deletions src/themes/shared/__index.css
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,4 @@
@import '_util.css';
@import '_mq.css';
@import '_classes.css';
@import '_rtl.css';
23 changes: 23 additions & 0 deletions src/themes/shared/_rtl.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
/* RTL specific styles */
body.rtl {
direction: rtl;
text-align: right;
}

/* Adjust sidebar for RTL */
body.rtl .sidebar {
left: auto;
right: 0;
}

body.rtl .content {
margin-left: auto;
margin-right: 300px; /* Assuming default sidebar width is 300px */
}

body.rtl .app-nav {
left: auto;
right: 0;
}

/* Add more specific RTL adjustments as needed */
46 changes: 46 additions & 0 deletions test/e2e/rtl.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
import docsifyInit from '../helpers/docsify-init.js';
import { test, expect } from './fixtures/docsify-init-fixture.js';

test.describe('RTL Mode', () => {
test('should render in RTL mode when rtl:true is set', async ({ page }) => {
// Initialize docsify with RTL configuration
await docsifyInit({
config: {
rtl: true,
// Add a sidebar to ensure it's rendered and we can test its position
loadSidebar: true,
},
markdown: {
homepage: '# Test RTL Page',
sidebar: `
* [Home](/)
* [Page2](/page2)
`,
},
// _logHTML: true, // Uncomment for debugging if needed
});

// Check if body has 'rtl' class
await expect(page.locator('body')).toHaveClass(/rtl/);

// Check sidebar visibility and position
const sidebar = page.locator('.sidebar');
await expect(sidebar).toBeVisible();

// Check computed style for sidebar position
// This is generally more robust than bounding box calculations if CSS is clear
await expect(sidebar).toHaveCSS('right', '0px');

// Optional: Bounding box check (can be more fragile due to scrollbars, etc.)
// const sidebarBoundingBox = await sidebar.boundingBox();
// const viewportWidth = page.viewportSize().width;
// expect(sidebarBoundingBox.x + sidebarBoundingBox.width).toBeCloseTo(viewportWidth, 2); // Allow 2px tolerance

// Check content area position (to ensure it's not overlapping with the right-aligned sidebar)
const content = page.locator('.content');
await expect(content).toBeVisible();
// The CSS for .content in RTL is `margin-right: 300px;`
// We can check if its left side is not at 0, or its right margin is indeed 300px
await expect(content).toHaveCSS('margin-right', '300px');
});
});
Loading