refactor: optimize subscription implementations with DashMap and shared trait #87
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize Subscription Implementations
This PR optimizes the subscription implementations in the Torii project by:
RwLock<HashMap>
withDashMap
for all subscription managers to reduce lock contentionSubscriptionManager
trait for all subscription types to maximize code reuseSubscriberSender
trait implementation for all subscriber typesBenefits
Testing
All clippy and formatting checks pass. The implementation maintains the existing API surface for backward compatibility.
Link to Devin run: https://app.devin.ai/sessions/45abe01d37394e15acab937b295999cb
Requested by: [email protected]