-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[Blazor] Adds support for persisting and restoring disconnected circuits from storage #62259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
javiercn
merged 23 commits into
main
from
javiercn/persistent-component-state-ungraceful
Jun 11, 2025
Merged
[Blazor] Adds support for persisting and restoring disconnected circuits from storage #62259
javiercn
merged 23 commits into
main
from
javiercn/persistent-component-state-ungraceful
Jun 11, 2025
+2,124
−114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 5, 2025
7116e55
to
70da07d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great so far - still need to do a deeper review of some parts.
src/Components/Server/src/Circuits/CircuitPersistenceManager.cs
Outdated
Show resolved
Hide resolved
src/Components/Server/src/Circuits/CircuitPersistenceManager.cs
Outdated
Show resolved
Hide resolved
src/Components/Server/src/Circuits/DefaultPersistedCircuitCache.cs
Outdated
Show resolved
Hide resolved
src/Components/Server/src/Circuits/DefaultPersistedCircuitCache.cs
Outdated
Show resolved
Hide resolved
src/Components/Server/src/Circuits/IServerComponentDeserializer.cs
Outdated
Show resolved
Hide resolved
src/Components/Server/src/Circuits/DefaultPersistedCircuitCache.cs
Outdated
Show resolved
Hide resolved
ilonatommy
reviewed
Jun 9, 2025
src/Components/Server/src/Circuits/CircuitPersistenceManager.cs
Outdated
Show resolved
Hide resolved
src/Components/Server/src/Circuits/DefaultPersistedCircuitCache.cs
Outdated
Show resolved
Hide resolved
70da07d
to
7820b1b
Compare
cf5a455
to
aea83a7
Compare
MackinnonBuck
approved these changes
Jun 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
aea83a7
to
8582da8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details to be added. There are some missing things on this PR that will be done in separate PRs:
HybridCache
as a base implementation.The detailed design can be found #60494
The main changes from the original design as well as some additional details are: