Clarify CookieContainer thread-safety #11171
Conversation
github-actions
bot
added
the
needs-area-label
antonfirsov
added
area-System.Net
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/ncl |
|
Learn Build status updates of commit b3f9a00:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| xml/System.Net/CookieContainer.xml | View | Details |
xml/System.Net/CookieContainer.xml
- Line 0, Column 0: [Warning: disallowed-html-tag - See documentation]
HTML tag 'format' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
| @@ -79,6 +79,19 @@ | |||
|
|
|||
| ]]></format> | |||
| </remarks> | |||
| <threadsafe> | |||
There was a problem hiding this comment.
Yes, but looks like it cannot handle embedded <format> :( Will move the content to <remarks>.
Co-authored-by: Genevieve Warren <[email protected]>
|
Learn Build status updates of commit 26d016e:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| xml/System.Net/CookieContainer.xml | View | Details |
xml/System.Net/CookieContainer.xml
- Line 0, Column 0: [Warning: disallowed-html-tag - See documentation]
HTML tag 'format' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
This PR supplements dotnet/docs#45658 by clarifying that
CookieContainermethods are thread-safe but also noting the dangers of unanticipadedCookieContainersharing.Fixes #1535
Fixes #10770