Update Live with current Master #3136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Space characters are encoded as '+' Existing description implies that the specified character classes are the only exceptions to hexadecimal encoding. I'm trying to match Javascript 'encodeURIComponent' behavior, and expected WebUtility.UrlEncode to provide this. However, as spaces are a further exception, this method produces results that are functionally identical to that produced by HttpUtility.UrlEncode. Might also be useful to mention Uri.EscapeDataString and AntiXss.UrlEncode as well here, as these are now preferred options when looking to encode URIs in a transparent, reversible manner. * Update xml/System.Net/WebUtility.xml As requested, removed reference to HttpUtility. Thanks @davidsh and @mairaw Co-Authored-By: Maira Wenzel <[email protected]>
* Fixes to PrepareAsync * Made cancellation token description more consistent and added note where default values are present. * Changed default value for cancellation tokens to be CancellationToken.None instead of null
|
Opened PR #3137 to fix the warnings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Live with current Master