Skip to content

Dependency version updates #7457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 20, 2025
Merged

Conversation

michaelgsharp
Copy link
Contributor

Update most dependency versions.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates dependency versions and deprecates several test methods by adding [Obsolete] attributes and related warning suppressions. The key changes include:

  • Marking diagnostic and test methods as obsolete to indicate deprecation.
  • Adding SuppressMessage attributes with pending justifications in one test file.
  • Updating a test to be skipped with an accompanying obsolete marker.

Reviewed Changes

Copilot reviewed 28 out of 38 changed files in this pull request and generated 3 comments.

File Description
test/Microsoft.ML.CodeAnalyzer.Tests/Helpers/CSharpCodeFixVerifier`2.cs Added [Obsolete] attributes to the Diagnostic() overloads and applied warning suppression around an internal test class.
test/Microsoft.ML.CodeAnalyzer.Tests/Code/TypeParamNameTest.cs Added an [Obsolete] attribute on the test method.
test/Microsoft.ML.CodeAnalyzer.Tests/Code/RelaxTestNamingTest.cs Introduced multiple SuppressMessage attributes with "" justifications.
Others Similar [Obsolete] attributes were added across various test files to mark methods for future deprecation.
Files not reviewed (10)
  • docs/samples/Microsoft.ML.GenAI.Samples/Microsoft.ML.GenAI.Samples.csproj: Language not supported
  • docs/samples/Microsoft.ML.Samples/Microsoft.ML.Samples.csproj: Language not supported
  • eng/Versions.props: Language not supported
  • src/Microsoft.ML.AutoML.Interactive/Microsoft.ML.AutoML.Interactive.csproj: Language not supported
  • src/Microsoft.ML.AutoML/Microsoft.ML.AutoML.csproj: Language not supported
  • src/Microsoft.ML.GenAI.Core/Microsoft.ML.GenAI.Core.csproj: Language not supported
  • src/Microsoft.ML.GenAI.Mistral/Microsoft.ML.GenAI.Mistral.csproj: Language not supported
  • src/Microsoft.ML.GenAI.Phi/Microsoft.ML.GenAI.Phi.csproj: Language not supported
  • test/Microsoft.ML.GenAI.Core.Tests/Microsoft.ML.GenAI.Core.Tests.csproj: Language not supported
  • test/Microsoft.ML.GenAI.LLaMA.Tests/Microsoft.ML.GenAI.LLaMA.Tests.csproj: Language not supported

Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.99%. Comparing base (f6221d5) to head (4f6bd49).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7457   +/-   ##
=======================================
  Coverage   68.99%   68.99%           
=======================================
  Files        1482     1482           
  Lines      273879   273880    +1     
  Branches    28254    28254           
=======================================
+ Hits       188965   188967    +2     
+ Misses      77531    77526    -5     
- Partials     7383     7387    +4     
Flag Coverage Δ
Debug 68.99% <ø> (+<0.01%) ⬆️
production 63.28% <ø> (+<0.01%) ⬆️
test 89.45% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...CodeAnalyzer.Tests/Code/InstanceInitializerTest.cs 0.00% <ø> (-100.00%) ⬇️
...t/Microsoft.ML.CodeAnalyzer.Tests/Code/NameTest.cs 100.00% <ø> (ø)
...deAnalyzer.Tests/Code/ParameterVariableNameTest.cs 100.00% <ø> (ø)
...alyzer.Tests/Code/SingleVariableDeclarationTest.cs 100.00% <ø> (ø)
...ft.ML.CodeAnalyzer.Tests/Code/TypeParamNameTest.cs 100.00% <ø> (ø)
...eAnalyzer.Tests/Helpers/CSharpCodeFixVerifier`2.cs 70.00% <ø> (ø)

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ericstj ericstj assigned ericstj and unassigned michaelgsharp May 16, 2025
@ericstj
Copy link
Member

ericstj commented May 19, 2025

Mac tests completing but then crashing at process exit:|

�[m�[37m   Microsoft.ML.Tests  Total: 908, Errors: 0, Failed: 0, Skipped: 51, Time: 134.207s
�[m�[mlibc++abi: terminating due to uncaught exception of type std::__1::system_error: mutex lock failed: Invalid argument
./runTests.sh: line 25: 13938 Abort trap: 6           (core dumped) dotnet exec --roll-forward Major --runtimeconfig Microsoft.ML.Tests.runtimeconfig.json --depsfile Microsoft.ML.Tests.deps.json $HELIX_CORRELATION_PAYLOAD/xunit-runner/tools/netcoreapp2.0/xunit.console.dll Microsoft.ML.Tests.dll -notrait Category=SkipInCI -xml testResults.xml
/private/tmp/helix/working/A97F0942/w/A58708E8/e
----- end Mon May 19 14:37:20 EDT 2025 ----- exit code 134 ----------------------------------------------------------
+ export _commandExitCode=134

@ericstj
Copy link
Member

ericstj commented May 19, 2025

Trying to update .NET runtime. If that doesn't help, we'll need to isolate the source of this error. Looks like it was present in @michaelgsharp's earlier work.

<MicrosoftCodeAnalysisCSharpVersion>4.13.0</MicrosoftCodeAnalysisCSharpVersion>
<MicrosoftDotNetInteractiveVersion>1.0.0-beta.25177.1</MicrosoftDotNetInteractiveVersion>
<MicrosoftMLOnnxRuntimeVersion>1.21.0</MicrosoftMLOnnxRuntimeVersion>
<MicrosoftMLOnnxRuntimeManagedVersion>1.21.2</MicrosoftMLOnnxRuntimeManagedVersion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this property used anywhere.

Suggested change
<MicrosoftMLOnnxRuntimeManagedVersion>1.21.2</MicrosoftMLOnnxRuntimeManagedVersion>

@ericstj ericstj mentioned this pull request May 19, 2025
@ericstj
Copy link
Member

ericstj commented May 19, 2025

Found a customer report of the same issue microsoft/onnxruntime#24579

@ericstj
Copy link
Member

ericstj commented May 20, 2025

Still broken with latest, will try to go back to older package.

@ericstj ericstj merged commit d105477 into dotnet:main May 20, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants