Skip to content

Skip calling certain Tasks if the input is empty #22689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dellis1972
Copy link
Contributor

@dellis1972 dellis1972 commented Apr 29, 2025

Fixes #19600

Add conditionals to check if ItemGroups are not empty before executing a Task on a remove machine.

@dellis1972 dellis1972 marked this pull request as ready for review April 29, 2025 07:49
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #97ae637] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 97ae6373828cb262f3b263b9a018940b942f2b8a [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #97ae637] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 97ae6373828cb262f3b263b9a018940b942f2b8a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #97ae637] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 97ae6373828cb262f3b263b9a018940b942f2b8a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #97ae637] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 97ae6373828cb262f3b263b9a018940b942f2b8a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #97ae637] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 97ae6373828cb262f3b263b9a018940b942f2b8a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #97ae637] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 97ae6373828cb262f3b263b9a018940b942f2b8a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #97ae637] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 97ae6373828cb262f3b263b9a018940b942f2b8a [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 97ae6373828cb262f3b263b9a018940b942f2b8a [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build #97ae637] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 120 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 97ae6373828cb262f3b263b9a018940b942f2b8a [PR build]

@dellis1972
Copy link
Contributor Author

I'm sorry I didn't have time to fully test this before the move. But it should be a good start.

@rolfbjarne
Copy link
Member

Marking as draft until this is completed.

@rolfbjarne rolfbjarne marked this pull request as draft May 1, 2025 06:36
@rolfbjarne rolfbjarne self-assigned this May 16, 2025
@rolfbjarne
Copy link
Member

This would ideally have some tests. I'll look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Windows build perf] Tasks with no inputs should not be executed remotely
4 participants