Skip to content

[dotnet] Improve entitlements lookup for AdditionalAppExtensions. Fixes #19242. #22882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025

Conversation

rolfbjarne
Copy link
Member

  • Add support for a 'CodesignEntitlements' metadata to the 'AdditionalAppExtensions' item group, to make it easier to specify the entitlements for such an app extension.
  • Warn if no entitlements are set for app extensions in 'AdditionalAppExtensions' items.

Fixes #19242.

#19242.

* Add support for a 'CodesignEntitlements' metadata to the 'AdditionalAppExtensions' item group, to make it easier to specify the entitlements for such an app extension.
* Warn if no entitlements are set for app extensions in 'AdditionalAppExtensions' items.

Fixes #19242.
@rolfbjarne rolfbjarne requested review from emaf and mauroa as code owners May 22, 2025 14:44
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #8ecda16] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 8ecda160164ac44ed192f42a3573a7d9983bdf14 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #8ecda16] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 8ecda160164ac44ed192f42a3573a7d9983bdf14 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 8ecda160164ac44ed192f42a3573a7d9983bdf14 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #8ecda16] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 8ecda160164ac44ed192f42a3573a7d9983bdf14 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #8ecda16] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 8ecda160164ac44ed192f42a3573a7d9983bdf14 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #8ecda16] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 8ecda160164ac44ed192f42a3573a7d9983bdf14 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #8ecda16] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 8ecda160164ac44ed192f42a3573a7d9983bdf14 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #8ecda16] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 8ecda160164ac44ed192f42a3573a7d9983bdf14 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build #8ecda16] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 115 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 8ecda160164ac44ed192f42a3573a7d9983bdf14 [PR build]

@rolfbjarne rolfbjarne merged commit d588d0e into main May 28, 2025
44 checks passed
@rolfbjarne rolfbjarne deleted the dev/rolf/issue-19242 branch May 28, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AdditionalAppExtensions: .entitlements file location - better lookup or error
5 participants