Remove legacy resource editor #9654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the legacy resource editor from the `Microsoft.VisualStudio.Editors` assembly. It has been functionally replaced by the newer Resource Explorer. Some utility code had to be moved around to keep things building, and the `Microsoft.VisualStudio.Editors.ResxItemWizard` class is public API that's consumed from various components such as templates.
drewnoakes
commented
Apr 15, 2025
Comment on lines
235
to
237
| <data name="ResourceEditorFactory_GUID" xml:space="preserve"> | ||
| <value>ff4d6aca-9352-4a5f-821e-f4d6ebdcab11</value> | ||
| <value>81828910-b8b3-4d2b-99a3-067027c180c1</value> | ||
| <comment>{Locked}</comment> |
There was a problem hiding this comment.
We may wish to revert this, and instead use the same (legacy) GUID for Resource Explorer. In that way, existing code across the tree and extensions will continue to work, just with the new editor.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
drewnoakes
added
the
Feature-Resource-Designer
JakeRadMSFT
approved these changes
May 5, 2025
We will use the same GUID for the new editor now that this one has been removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow