-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Fix issue #70183: adjust the plural for expression collection #78110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jjonescz
merged 3 commits into
dotnet:main
from
kirisky:70183-adjust-the-plural-for-collection-expressions
Apr 15, 2025
Merged
Fix issue #70183: adjust the plural for expression collection #78110
jjonescz
merged 3 commits into
dotnet:main
from
kirisky:70183-adjust-the-plural-for-collection-expressions
Apr 15, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlekseyTs
reviewed
Apr 11, 2025
src/Compilers/CSharp/Test/Emit3/Semantics/CollectionExpressionTests.cs
Outdated
Show resolved
Hide resolved
kirisky
commented
Apr 13, 2025
AlekseyTs
reviewed
Apr 14, 2025
Done with review pass (commit 2) |
AlekseyTs
approved these changes
Apr 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (commit 3)
@dotnet/roslyn-compiler For the second review |
jjonescz
approved these changes
Apr 15, 2025
Thanks for the contribution @kirisky |
This was referenced Apr 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area-Compilers
Community
The pull request was submitted by a contributor who is not a Microsoft employee.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #70183