Add more tests for SmtpClient #114690
Merged
Add more tests for SmtpClient #114690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @dotnet/ncl |
src/libraries/System.Net.Mail/tests/Functional/SmtpClientAttachmentTest.cs
Outdated
Show resolved
Hide resolved
…hmentTest.cs Co-authored-by: Copilot <[email protected]>
This was referenced Apr 15, 2025
rokonec
approved these changes
Apr 16, 2025
| @@ -201,13 +247,32 @@ await SendMessageAsync( | |||
|
|
|||
| switch (command.ToUpper()) | |||
| { | |||
| case "STARTTLS": | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a number of functional tests for the SmptClient. The idea is to map out the current behavior of all 3 ways of sending messages:
This will give us more confidence for potential future modernization of the code base.
Combining with Unit tests (untouched in this PR), this increases the line coverage from 67% to 75% and branch coverage from 59% to 63%. Lines of interest that are not yet covered seem to be mostly exception propagation in the asynchronous Begin/End method chains and would require targeted test for each step of the chain to cover fully.