Skip to content

Notify debuggers on rethrown exceptions #116246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025
Merged

Notify debuggers on rethrown exceptions #116246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/ExceptionHandling.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -739,11 +739,18 @@ public static void RhUnwindAndIntercept(ref ExInfo exInfo, UIntPtr interceptStac
public static void RhRethrow(ref ExInfo activeExInfo, ref ExInfo exInfo)
{
#if NATIVEAOT

#if TARGET_WINDOWS
// Alert the debugger that we threw an exception.
InternalCalls.RhpFirstChanceExceptionNotification();
#endif // TARGET_WINDOWS

// trigger a GC (only if gcstress) to ensure we can stackwalk at this point
GCStress.TriggerGC();

InternalCalls.RhpValidateExInfoStack();
#endif
#endif // NATIVEAOT

// We need to copy the exception object to this stack location because collided unwinds
// will cause the original stack location to go dead.
object rethrownException = activeExInfo.ThrownException;
Expand Down