Skip to content

[BLOCKED] System.CommandLine update #46241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from

Conversation

adamsitnik
Copy link
Member

@adamsitnik adamsitnik commented Jan 23, 2025

Edit: this PR is blocked until NuGet/NuGet.Client#6236 gets merged (ETA is April).

Context: we are working on releasing a new public version of System.CommandLine. The only change we decided to revert was the adding of "Cli" prefix to all symbol types (because it would break every single user of the library).

dotnet-maestro bot and others added 2 commits January 23, 2025 05:01
…uild 20250122.1

Microsoft.SourceBuild.Intermediate.command-line-api , System.CommandLine , System.CommandLine.Rendering
 From Version 0.1.607102 -> To Version 0.1.607201
@adamsitnik adamsitnik requested a review from baronfel January 23, 2025 12:40
@adamsitnik adamsitnik requested review from a team and sharwell as code owners January 23, 2025 12:40
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Request triage from a team member label Jan 23, 2025
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

1 similar comment
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for dotnet test and dotnet vstest

@adamsitnik adamsitnik changed the base branch from darc-main-22c0f35e-0174-4ebd-9a97-121a1785191e to main January 29, 2025 10:55
# Conflicts:
#	src/Cli/dotnet/CommonOptions.cs
#	src/Cli/dotnet/commands/InstallingWorkloadCommand.cs
#	src/Cli/dotnet/commands/dotnet-run/RunCommandParser.cs
#	src/Cli/dotnet/commands/dotnet-test/Program.cs
#	src/Cli/dotnet/commands/dotnet-test/TestCommandParser.cs
#	src/Cli/dotnet/commands/dotnet-workload/search/WorkloadSearchVersionsCommandParser.cs
adamsitnik and others added 2 commits February 3, 2025 09:59
…0250131.2

Microsoft.SourceBuild.Intermediate.sourcelink , Microsoft.Build.Tasks.Git , Microsoft.SourceLink.AzureRepos.Git , Microsoft.SourceLink.Bitbucket.Git , Microsoft.SourceLink.Common , Microsoft.SourceLink.GitHub , Microsoft.SourceLink.GitLab
 From Version 10.0.0-beta.25080.2 -> To Version 10.0.0-beta.25081.2
dotnet-maestro bot and others added 2 commits February 4, 2025 14:51
…203.6

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions
 From Version 10.0.0-beta.25080.7 -> To Version 10.0.0-beta.25103.6
@adamsitnik adamsitnik changed the title adjust to System.CommandLine renaming [BLOCKED] System.CommandLine update Feb 6, 2025
@adamsitnik adamsitnik marked this pull request as draft February 6, 2025 11:27
@adamsitnik adamsitnik self-assigned this Feb 6, 2025
@adamsitnik adamsitnik added Blocked Issue is blocked on an external dependency DO NOT MERGE and removed untriaged Request triage from a team member labels Feb 6, 2025
@adamsitnik
Copy link
Member Author

The changes got included in #48477

@adamsitnik adamsitnik closed this Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Issue is blocked on an external dependency DO NOT MERGE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants