Add the test verifying property functions used in dotnet console/webapp don't need a reflection #48475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pp dont need a reflection
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
There was a problem hiding this comment.
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
Files not reviewed (1)
- test/TestAssets/TestProjects/MSBuildBareBonesProject/BareBones.proj: Language not supported
Comments suppressed due to low confidence (2)
test/Microsoft.NET.Build.Tests/EvaluatorFastPathTests.cs:58
- Consider verifying that the log file exists before reading from it to prevent potential exceptions if the file is missing.
var lines = File.ReadAllLines(logPath);
test/Microsoft.NET.Build.Tests/EvaluatorFastPathTests.cs:28
- [nitpick] Consider extracting the log file name "PropertyFunctionsRequiringReflection" into a named constant to avoid duplication and potential discrepancies in future updates.
var logPath = Path.Combine(testAsset.Path, "PropertyFunctionsRequiringReflection");
YuliiaKovalova
approved these changes
Apr 23, 2025
JanProvaznik
approved these changes
Apr 23, 2025
| [Theory] | ||
| [InlineData("console")] | ||
| [InlineData("webapp")] | ||
| public void EnsureDotnetCommonProjectPropertyFunctionsOnFastPath(string alias) |
There was a problem hiding this comment.
Suggested change
| public void EnsureDotnetCommonProjectPropertyFunctionsOnFastPath(string alias) | |
| public void EnsureDotnetCommonProjectPropertyFunctionsOnFastPath(string alias_) |
alias is a keyword so let's avoid it as a name for variable
| { | ||
| var testDir = _testAssetsManager.CreateTestDirectory().Path; | ||
|
|
||
| new DotnetNewCommand(Log, alias) |
There was a problem hiding this comment.
Suggested change
| new DotnetNewCommand(Log, alias) | |
| new DotnetNewCommand(Log, alias_) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/msbuild#10406
ToolLocationHelper property functions still require reflection and it's tracked by dotnet/msbuild#10411. For other functions the test is covered.