Skip to content

Skip all dotnet-watch tests on non-Windows platforms #49336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2025

Conversation

tmat
Copy link
Member

@tmat tmat commented Jun 11, 2025

No description provided.

@Copilot Copilot AI review requested due to automatic review settings June 11, 2025 00:39
@tmat tmat requested review from arunchndr and a team as code owners June 11, 2025 00:39
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the test suite to skip additional tests on Unix systems due to a known issue.

  • Adds a skip attribute to the HostRestart test in RuntimeProcessLauncherTests.cs.
  • Adds a skip attribute to the AutoRestartOnRudeEditAfterRestartPrompt test in ApplyDeltaTests.cs.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
test/dotnet-watch.Tests/HotReload/RuntimeProcessLauncherTests.cs Adds a skip attribute to bypass the HostRestart test on Unix platforms.
test/dotnet-watch.Tests/HotReload/ApplyDeltaTests.cs Adds a skip attribute to bypass the AutoRestartOnRudeEditAfterRestartPrompt test on Unix platforms.
Comments suppressed due to low confidence (2)

test/dotnet-watch.Tests/HotReload/RuntimeProcessLauncherTests.cs:399

  • Consider adding an inline comment or a TODO note above the skip attribute detailing when this skip can be removed (e.g., once the referenced issue is resolved) to enhance clarity for future maintainers.
[SkipOnPlatform(TestPlatforms.AnyUnix, "https://github.com/dotnet/sdk/issues/49307")]

test/dotnet-watch.Tests/HotReload/ApplyDeltaTests.cs:109

  • Consider adding an inline comment or a TODO note above the skip attribute to indicate when this skip may be revisited, ensuring clarity on the temporary nature of this workaround.
[SkipOnPlatform(TestPlatforms.AnyUnix, "https://github.com/dotnet/sdk/issues/49307")]

@v-wuzhai
Copy link
Member

Superseded by #49357

@v-wuzhai v-wuzhai closed this Jun 12, 2025
@tmat tmat reopened this Jun 12, 2025
@tmat tmat changed the title Skip more tests Skip all dotnet-watch tests on non-Windows platforms Jun 12, 2025
@tmat tmat mentioned this pull request Jun 12, 2025
@marcpopMSFT marcpopMSFT merged commit fa2361b into dotnet:main Jun 12, 2025
30 checks passed
@tmat tmat deleted the SkipMoreTests branch June 12, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants