Skip to content

[FEATURE REQUEST]: Add Application .Zip file contents to Assembly Search Path #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AeroXuk opened this issue Jul 31, 2019 · 2 comments · May be fixed by #193 or #194
Open

[FEATURE REQUEST]: Add Application .Zip file contents to Assembly Search Path #192

AeroXuk opened this issue Jul 31, 2019 · 2 comments · May be fixed by #193 or #194
Labels
enhancement New feature or request

Comments

@AeroXuk
Copy link

AeroXuk commented Jul 31, 2019

Is your feature request related to a problem? Please describe.
This is in relation to one of the new features added in v0.4.0:

The --archives option only works for YARM setups. Databricks, for example, does not use YARM so the --archives parameter has no effect.

Describe the solution you'd like
For the application .zip file to be transferred to all workers, extracted and the contents to be in the assembly search path.

Describe alternatives you've considered
A partial workaround is adding the applications .zip file name to the --files parameter meets the first requirement of transferring it to all workers. However, it is not automatically extracted or added to the assembly search path.

Databricks Spark-Submit example:

["--files","DotNetSparkTest.zip","--class","org.apache.spark.deploy.dotnet.DotnetRunner","/dbfs/spark-dotnet/microsoft-spark-2.4.x-0.4.0.jar","/dbfs/apps/DotNetSparkTest.zip","DotNetSparkTest"]
@AeroXuk
Copy link
Author

AeroXuk commented Aug 1, 2019

I have created two alternative pull requests for two different ways of fixing this.

Option 1 - #193 - Unzips all .zip archives in the working directory.
Option 2 - #194 - Only unzips a .zip archive matching the Application Archive name.

Both options then add the extracted folder to the Assembly Search Path.

@imback82
Copy link
Contributor

@suhsteve can you take a look at these two PRs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants