Add zip files in working directory to assembly search path #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sembly search path.
AeroXuk
commented
Jul 31, 2019
| FileInfo[] archives = new DirectoryInfo(Directory.GetCurrentDirectory()) | ||
| .GetFiles("*.zip"); | ||
| foreach (var archive in archives) | ||
| { |
There was a problem hiding this comment.
Personally, rather than extracting all .zip files within the folder. I would prefer to extract only the applications .zip file if present. I don't, however, know the project well enough to know if it is possible to access the application .zip parameter that's passed to DotNetRunner from C#.
There was a problem hiding this comment.
See #194 as an alternative way of potentially implementing this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change extracts any zip files within the working directory and adds the extracted folders to the assembly search path. When combined with the
--filesparameter allows you to copy the application dependencies to all workers and adds them to the assembly search path.Fixes #192