Autowire adapter services for incremental migration with aspire #597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CZEMacLeod I'd appreciate any thoughts you have here as well. I know you have some similar APIs in one of your projects, but the goal here would be to plumb things through so they can just work and requires a bit more deeper plumbing to allow the services to be autowired together. |
CZEMacLeod
reviewed
Jun 12, 2025
src/Microsoft.AspNetCore.SystemWebAdapters.FrameworkServices/SystemWebAdapterExtensions.cs
Outdated
Show resolved
Hide resolved
CZEMacLeod
reviewed
Jun 12, 2025
CZEMacLeod
reviewed
Jun 12, 2025
src/Microsoft.AspNetCore.SystemWebAdapters.Aspire/IncrementalMigrationResourceExtensions.cs
Outdated
Show resolved
Hide resolved
CZEMacLeod
reviewed
Jun 12, 2025
src/Microsoft.AspNetCore.SystemWebAdapters.Aspire/AspireConstants.Shared.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables auto-configuration of the adapter services based off of the configuration set in aspire. This will ensure that things are wired up correctly for each and only has to be declared in a single space.
This is currently a proof of concept to see how much we can simplify the process of incremental migration with Aspire.