Refactor WeakReferenceList/CopyOnWriteList as type-safe generic collections

[h3xds1nz]

Description

Refactors both CopyOnWriteList and WeakReferenceList as generic type-safe collections.

• Theoretically, they could have been merged into one but I chose not to currently.

Both lists now support initialization with capacity argument, previously integers passed in (e.g. in PropagateParentOwners) would end up being boxed and the instance of the box being used as a lock. This clearly feels like a mistake.

In ResourceDictionaryDiagnostics I've removed few static fields caching empty (readonly) arrays I didn' see in #10267.

Regarding the removed null-checks:

• Those are a part of the as casting pattern.
• The enumerator returns strong, non-null references, hence it will never be null in the first place.
• I've appropriately null-annotated the adjusted files.

Since ContainsOwner is only called from within the three classes, we can remove the type checks and speed it up.

• Similarly it can be done for Add/Remove but I'll do that after this is in.

Customer Impact

Improved performance a tiny bit, strongly-typed code and newer practices.

Regression

No.

Testing

Local build, unit tests, testing with sample apps including themes and templates.

Risk

Low to medium, I believe the changes are straightforward and understandable but happy to answer any questions (rather sooner than later).

Microsoft Reviewers: Open in CodeFlow

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 249 lines in your changes missing coverage. Please review.

Project coverage is 2.98844%. Comparing base (57fe8ac) to head (3b36966).
Report is 12 commits behind head on main.

Additional details and impacted files

@@                 Coverage Diff                 @@
##                main     #10889          +/-   ##
===================================================
- Coverage   13.48885%   2.98844%   -10.50041%     
===================================================
  Files           3317       3319           +2     
  Lines         664749     664828          +79     
  Branches       74643      74664          +21     
===================================================
- Hits           89667      19868       -69799     
- Misses        572488     644779       +72291     
+ Partials        2594        181        -2413     

Flag	Coverage Δ
Debug	2.98844% <0.00000%> (-10.50041%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Arkane5]

Just a tiny fix for coherence.

[Arkane5]

Same fix as above

Suggested change

	/// For use by derived classes that implement there own error checks.
	/// For use by derived classes that implement their own error checks.