rg/pg_array #2
Open
rg/pg_array #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redshift does not support arrays, and dump was using pg_index.indkey which is unsupported INT2VECTOR type. Haven't found other workaround for now than removing the primary key check and setting it always to false. In mean time you can set it at the model level with `set_primary_key`.
- Redshift doesn't support TEXT type, use char or varchar only - Redshift doesn't support RETURNING at all, so we shouldn't respond with true for that
Add default adapter options
Added DISTKEY and SORTKEY SQL fragments to column definition methods
Redshift does not support DROP TABLE IF EXISTS
This is instead loaded from spec/database.yml - an example file is provided. This allows different people to run tests on their own redshift clusters. In addition, tests have been moved under a test-specific schema - this needs to be created before runnning tests on your cluster.
The latest (4.13 as of writing) version of Sequel doesn't seem to pay any attention to supports_returning? anymore. There is a method/opts value called disable_insert_returning that has been added back in - just ensure that this is set all the time on a dataset.
this prevents savepoint from firing inside transaction loop
MS: Sequel 5 support
rg-fix-table-exists
Table attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attempt to add Redshift support for pg_array
what was done:
supercolumn on insertion and serialization on fetching rowrs_jointo array_ops