Skip to content

Builds the plugin using dune #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Builds the plugin using dune #378

wants to merge 9 commits into from

Conversation

bmourad01
Copy link
Contributor

@bmourad01 bmourad01 commented Jan 10, 2023

Since BAP switched the default build system to dune, we should do the same for our plugins.

bmourad01 added 2 commits January 11, 2023 10:40
Latest commit to BAP upstream is a better fix
Copy link

@ivg ivg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions, otherwise looks good!

@XVilka
Copy link

XVilka commented Apr 2, 2023

There are conflicts now. Any updates to get this merged, by the way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants